[U-Boot] [PATCH 05/12] MX6: add boot device support for SPL

[Stefano Babic]

Hi Tim,

On 05/05/2014 17:46, Tim Harvey wrote:

>> Just a little remark. Do you have written the function on your own or
>> have you ported it from Freescale's 2009.08 ? Apart names, it looks similar.
>>
>> If this is the case, you should also add Freescale's Copyright to the
>> header.
> 
> Hi Stefano,
> 
> I've never looked at Freescales 2009.08 code myself (I have an
> aversion to vendor specific forks of u-boot almost 5 years old heh),
> but its likely bits of the function came from there originally but my
> inspiration likely came from Edward Lin's patch a while back. A
> switch/case seems the logical approach given the bitfield from the
> IMX6 reference manual with several don't-cares spread around and I
> felt that was much easier to read than trying to convert it all the
> shifts and masks.

This is ok - I want only to be sure that Copyright is maintained if code
is taken from somewhere else.

> 
> I can add additional copyright's if anyone feels its necessary - I've
> added Edward to the cc to see if he feels its necessary.

Ok - if nobody complains, you can leave it as it is now.

Best regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================