[U-Boot] [PATCH] zynq: ignore ps7_init.h

Michal Simek monstr at monstr.eu
Thu May 8 14:00:07 CEST 2014


On 05/08/2014 11:21 AM, Masahiro Yamada wrote:
> Hi Michal,
> 
>>
>> Here is just one question if we should also ignore ps7_init.c too.
>> It means move current ps7_init weak function to spl.c in mach-zynq
>> and just compile ps7_init.c in board file if it is available there.
>>
>> Is there any nice hook in Kbuild to compile file if it is available?
>>
>> Something like
>> [ -f ps7_init.c ] && compile it
> 
> Nice suggestion!
> 
> 
>> Then we can just move weak function
>> and ignore ps7_init.c/h files in board file.
>>
> 
> This might not be beautiful very much, but
> we can write board/xilinx/zynq/Makefile like this:
> 
> obj-y	:= board.o
> obj-$(CONFIG_SPL_BUILD)	+= $(if $(wildcard $(srctree)/$(src)/ps7_init.c),ps7_init.o)

If this is acceptable by others I am quite happy to use it
because it seems to me like a good way how to handle it.

In future when everything is ready I expect that these ps7_init.c/h
files will go away and information will be read directly from DTS
but we are not there yet.

Anyway: Can you please prepare that patches? I am quite happy to test them
and adding it to my zynq queue and send it to Albert.

Or do you want me to prepare them?

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140508/e17bb3c5/attachment.pgp>


More information about the U-Boot mailing list