[U-Boot] [PATCH v4 1/3] usb:gadget:f_thor: code cleanup in function download_tail()

Marek Vasut marex at denx.de
Sat May 10 11:41:16 CEST 2014


On Friday, May 09, 2014 at 10:35:54 AM, Lukasz Majewski wrote:
> Hi Przemyslaw, Marek,
> 
> > Hello Marek,
> > 
> > On 04/28/2014 06:57 PM, Przemyslaw Marczak wrote:
> > > In thor's download_tail() function, dfu_get_entity() is called
> > > before each dfu_write() call and the returned entity pointers
> > > are the same. So dfu_get_entity() can be called just once and
> > > this patch changes this.
> > > 
> > > Signed-off-by: Przemyslaw Marczak <p.marczak at samsung.com>
> > > Cc: Lukasz Majewski <l.majewski at samsung.com>
> > > Cc: Marek Vasut <marex at denx.de>
> > > Cc: Heiko Schocher <hs at denx.de>
> > > Cc: Tom Rini <trini at ti.com>
> > > 
> > > ---
> > > Changes v2:
> > > - separate fix and cleanup into two commits
> > > 
> > > Changes v3:
> > > - download_tail(): add exit label
> > > 
> > > Changes v4:
> > > - none
> > 
> > I've checked the u-boot-usb/master tree and I found that one commit
> > of this patch set is missed, because it is v3 (there was only two
> > commits). Could you please apply the patch set version 4?
> 
> I've discussed this issue with Przemek, and we agreed that Przemek will
> prepare diff patch between version 3, which is already in mainline and
> version 4.
> 
> Then, after ML review, I will pull them to u-boot-dfu branch.
> 
> Marek, does it work for you?

Yes, thanks.

Best regards,
Marek Vasut


More information about the U-Boot mailing list