[U-Boot] [PATCH v2] Because sandbox is not a real hardware, setting vendor=sandbox is almost meaningless.

Masahiro Yamada yamada.m at jp.panasonic.com
Wed May 14 05:57:37 CEST 2014


Hi Simon,

On Tue, 13 May 2014 12:13:48 -0600
Simon Glass <sjg at chromium.org> wrote:

> From: Masahiro Yamada <yamada.m at jp.panasonic.com>
> 
> This commit sets sandbox's vendor field to '-'.
> 
> It is a good thing that it reduces one level directory hierarchy.
> The files board/sandbox/sandbox/* have been moved to board/sandbox/*.
> 
> Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> (modified to apply to latest upstream)


I am not happy about this fix-up approach because the commit description
does not reflect the code any more.



> It is a good thing that it reduces one level directory hierarchy.

This sounds odd.
This patch moves arch/sandbox/lib/sandbox.c
to board/sandbox/sandbox.c,
creating board/sandbox/ directory.


We should revert the wrong commit first,
and then apply the right one.

I will send them.

Best Regards
Masahiro Yamada



More information about the U-Boot mailing list