[U-Boot] [PATCH v2 1/4] bootm: make use of legacy image format configurable

[Michal Simek]

On 05/15/2014 07:47 AM, Heiko Schocher wrote:
> Hello Michal,
> 
> Am 14.05.2014 13:16, schrieb Michal Simek:
>> On 05/14/2014 12:54 PM, Heiko Schocher wrote:
>>> make the use of legacy image format configurable through
>>> the config define CONFIG_IMAGE_FORMAT_LEGACY.
>>>
>>> When relying on signed FIT images with required signature check
>>> the legacy image format should be disabled. Therefore introduce
>>> this new define and enable legacy image format if CONFIG_FIT_SIGNATURE
>>> is not set. If CONFIG_FIT_SIGNATURE is set disable per default
>>> the legacy image format.
>>>
>>> Signed-off-by: Heiko Schocher<hs at denx.de>
>>> Cc: Simon Glass<sjg at chromium.org>
>>> Cc: Lars Steubesand<lars.steubesand at philips.com>
>>> Cc: Mike Pearce<mike at kaew.be>
>>> Cc: Wolfgang Denk<wd at denx.de>
>>> Cc: Tom Rini<trini at ti.com>
>>> Cc: Michal Simek<monstr at monstr.eu>
>>> Cc: Michael Conrad<Michael.Conrad at ids.de>
>>>
>>> ---
>>> - changes for v2:
>>>    - make the legacy image format configurable through
>>>      the define CONFIG_IMAGE_FORMAT_LEGACY.
>>>
>>>      Default:
>>>      if not CONFIG_FIT_SIGNATURE is defined it is enabled,
>>>      else disabled.
>>>
>>>      Disable it with CONFIG_DISABLE_IMAGE_LEGACY if
>>>      CONFIG_FIT_SIGNATURE is not defined.
>>
>> Just a note that ifdef CONFIG_IMAGE_FORMAT_LEGACY
>> should be also used in SPL code.
> 
> I think thats the case, as I did the default settings in
> include/config_defaults.h and a MAKEALL for arm and powerpc
> dropped no compiler errors/warnings.
> 
> This is just a first step to deactivate legacy image format.
> A complete remove patch of it needs more work/time ...

SPL is using just legacy image format.

> 
>> But that means that FIT image with signature feature
>> should be enabled for SPL.
> 
> Why?

I described this differently than I wanted.
Enable FIT for SPL as one step
and enabling FIT with signature is optional.

>> If possible please also enable CONFIG_IMAGE_FORMAT_LEGACY
>> for zynq because we are using legacy formats too.
> 
> You mean in "include/configs/zynq-common.h" ?
> Prepared this for v3, but I could not test it...

Yes. I will test it that's not a problem.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140515/948eb879/attachment.pgp>