[U-Boot] [PATCH v2] examples: select libgcc for non-default architecture

Wolfgang Denk wd at denx.de
Fri May 16 09:36:16 CEST 2014


Dear Masahiro,

In message <20140516160556.E1A8.AA925319 at jp.panasonic.com> you wrote:
> 
> > +# Add GCC lib
> > +ifdef CONFIG_USE_PRIVATE_LIBGCC
> > +ifeq ($(CONFIG_USE_PRIVATE_LIBGCC),y)
> > +PLATFORM_LIBGCC = arch/$(ARCH)/lib/lib.a
> > +else
> > +PLATFORM_LIBGCC = -L $(CONFIG_USE_PRIVATE_LIBGCC) -lgcc
> > +endif
> > +else
> > +PLATFORM_LIBGCC := -L $(shell dirname `$(CC) $(PLATFORM_CPPFLAGS) \
> > +				       -print-libgcc-file-name`) -lgcc
> > +endif
> 
> This is duplicating the code.
> 
> I think you should export PLATFORM_LIBGCC from the top Makefile
> and use it.

Yes, this is what I head in mind, too.  we already have this setting,
so there should be no need to redo it.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Your own mileage may vary.


More information about the U-Boot mailing list