[U-Boot] [PATCH] mx6sabre_common: Avoid console hang due to small CONFIG_SYS_PBSIZE

Fabio Estevam festevam at gmail.com
Mon May 19 04:02:43 CEST 2014


From: Fabio Estevam <fabio.estevam at freescale.com>

Entering the maximum number of characters defined by CONFIG_SYS_CBSIZE into 
the console and hitting enter afterwards, causes a hang in the system because
CONFIG_SYS_PBSIZE is not capable of storing the characters of the error message:
"Unknown command '' - try 'help'"

Increase the size of CONFIG_SYS_PBSIZE so that it can store the error message 
and allows the error message to be printed correctly with no hang.

Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
---
This problem affects many boards.

Maybe a global fix is to add a CONFIG_SYS_PBSIZE entry into config_fallbacks
and remove its definition from the board config files when it is defined as:
#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)

or even when it is equal to CONFIG_SYS_CBSIZE.

 include/configs/mx6sabre_common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/configs/mx6sabre_common.h b/include/configs/mx6sabre_common.h
index e59a3b4..6017a20 100644
--- a/include/configs/mx6sabre_common.h
+++ b/include/configs/mx6sabre_common.h
@@ -217,7 +217,7 @@
 #define CONFIG_SYS_CBSIZE              256
 
 /* Print Buffer Size */
-#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
+#define CONFIG_SYS_PBSIZE		384
 #define CONFIG_SYS_MAXARGS             16
 #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
 
-- 
1.8.3.2



More information about the U-Boot mailing list