[U-Boot] [PATCH v2 2/3] arm:at91: enable ROM loadable atmel image

[Andreas Bießmann]

On 05/19/2014 10:09 AM, Bo Shen wrote:
> On 05/19/2014 03:48 PM, Andreas Bießmann wrote:
>> On 05/19/2014 05:13 AM, Bo Shen wrote:
>>> On 05/16/2014 05:59 PM, Andreas Bießmann wrote:

<snip>

>>>> +#define CONFIG_SPL_AT91_HEADER_USE_PMECC    1
>>>> +#define CONFIG_SPL_AT91_HEADER_SECTOR_PER_PAGE    4
>>>> +#define CONFIG_SPL_AT91_HEADER_SECTOR_SIZE    CONFIG_PMECC_SECTOR_SIZE
>>>> +#define CONFIG_SPL_AT91_HEADER_SPARE_SIZE    64
>>>> +#define CONFIG_SPL_AT91_HEADER_ECC_BITS        CONFIG_PMECC_CAP
>>>> +#define CONFIG_SPL_AT91_HEADER_ECC_OFFSET    36
>>>
>>> Just a nitpick here:
>>>
>>> Can we take this parameter from the existing definition while not use
>>> new definition? Or else, if the header using different parameter with
>>> what u-boot nand driver use, then if flash through u-boot, it won't
>>> boot.
>>
>> I used the two parameters I found, sorry the rest isn't defiend anywhere
>> (or I can't find). Can you give me pointers to the other parameters?
> 
> Can we use the following information?
> 
> CONFIG_SPL_AT91_HEADER_USE_PMECC: CONFIG_ATMEL_NAND_HW_PMECC
> 
> CONFIG_SPL_AT91_HEADER_SECTOR_PER_PAGE: CONFIG_SYS_NAND_PAGE_SIZE /
> CONFIG_PMECC_SECTOR_SIZE

Unfortunately we cant do calculations within the Makefile. These
parameters will be given to command line and end up in  '-n
usePmecc=y,sectorPerPage="0x800/512",..'
This will make the atmelimage cmdline parsing way more difficult.

Does anybody know some way to solve this in Makefile?

Best regards

Andreas Bießmann