[U-Boot] [PATCH v2 10/12] exynos: dts: Enable LCD for snow

Simon Glass sjg at chromium.org
Tue May 20 13:53:35 CEST 2014


Hi Minkyu,

On 15 May 2014 00:51, Minkyu Kang <mk7.kang at samsung.com> wrote:
> On 03/04/14 08:24, Simon Glass wrote:
>> Enable LCD for snow. This is a 1366 x 768 panel.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>>
>> Changes in v2:
>> - Add a device tree node for the snow EDP bridge chip
>>
>>  arch/arm/dts/exynos5250-snow.dts | 57 ++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 57 insertions(+)
>>
>> diff --git a/arch/arm/dts/exynos5250-snow.dts b/arch/arm/dts/exynos5250-snow.dts
>> index 42a687b..2a6bc78 100644
>> --- a/arch/arm/dts/exynos5250-snow.dts
>> +++ b/arch/arm/dts/exynos5250-snow.dts
>> @@ -88,6 +88,19 @@
>>                       reg = <0x22>;
>>                       compatible = "maxim,max98095-codec";
>>               };
>> +
>> +             ptn3460-bridge at 20 {
>> +                     compatible = "nxp,ptn3460";
>> +                     reg = <0x20>;
>> +                     /*
>> +                      * TODO(sjg at chromium.org): Exynos GPIOs broken
>> +                      * powerdown-gpio = <&gpy2 5 0>;
>> +                      * reset-gpio = <&gpx1 5 0>;
>> +                      * edid-emulation = <5>;
>> +                      * pinctrl-names = "default";
>> +                      * pinctrl-0 = <&ptn3460_gpios>;
>> +                      */
>
> Now you can use GPIOs.

Yes it is a big help. However, I would like to make this change in a
follow-on series. It involves changing the code to stop hard-coding
the GPIOs. But there are many GPIOs involved, not just this bridge
chip, and not just the LCD. So I think we need a separate series after
this one to move the GPIOs to the device tree.

Regards,
Simon


More information about the U-Boot mailing list