[U-Boot] [PATCH] Prevent a stack overflow in fit_check_sign

[Simon Glass]

On 20 May 2014 03:58, Michael van der Westhuizen
<michael at smart-africa.com> wrote:
> It is trivial to crash fit_check_sign by invoking with an
> absolute path in a deeply nested directory.  This is exposed
> by vboot_test.sh.
>
> Signed-off-by: Michael van der Westhuizen <michael at smart-africa.com>

Acked-by: Simon Glass <sjg at chromium.org>

> ---
>  tools/fit_check_sign.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tools/fit_check_sign.c b/tools/fit_check_sign.c
> index d6d9340..817773d 100644
> --- a/tools/fit_check_sign.c
> +++ b/tools/fit_check_sign.c
> @@ -42,12 +42,13 @@ int main(int argc, char **argv)
>   void *fit_blob;
>   char *fdtfile = NULL;
>   char *keyfile = NULL;
> - char cmdname[50];
> + char cmdname[256];
>   int ret;
>   void *key_blob;
>   int c;
>
> - strcpy(cmdname, *argv);
> + strncpy(cmdname, *argv, sizeof(cmdname) - 1);
> + cmdname[sizeof(cmdname) - 1] = '\0';
>   while ((c = getopt(argc, argv, "f:k:")) != -1)
>   switch (c) {
>   case 'f':
> --
> 2.0.0.rc0