[U-Boot] [RFC, PATCH v2 1/4] dm: rename device struct to udevice

Jon Loeliger loeliger at gmail.com
Thu May 22 23:22:37 CEST 2014


Yeah, I was just bitten by this problem as well...

FWIW, you might also...

Acked-by: Jon Loeliger <Jon.Loeliger at oracle.com>

Thanks,
jdl

On Thu, May 22, 2014 at 3:34 PM, Simon Glass <sjg at chromium.org> wrote:
> +Tom
>
> Hi Heiko,
>
> On 22 May 2014 00:43, Heiko Schocher <hs at denx.de> wrote:
>> using UBI and DM together leads in compiler error, as
>> both define a "struct device", so rename "struct device"
>> in include/dm/device.h to "struct udevice", as we use
>> linux code (MTD/UBI/UBIFS some USB code,...) and cannot
>> change the linux "struct device"
>>
>> Signed-off-by: Heiko Schocher <hs at denx.de>
>> Cc: Simon Glass <sjg at chromium.org>
>> Cc: Marek Vasut <marex at denx.de>
>
> I'm not 100% comfortable with this but if we really want to avoid
> changing kernel code that moves into U-Boot it is either this or a
> '#define device ldevice' at the top of the linux code/in a header. I'm
> not sure which is preferable.
>
> If Tom decides to apply this, I'd like to request that it be done
> soon, since it has wide impact on driver model code.
>
> Acked-by: Simon Glass <sjg at chromium.org>
>
> Regards,
> Simon
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot


More information about the U-Boot mailing list