[U-Boot] [PATCH 4/4] kirkwood: Shorten DNS-325 IDENT_STRING to match DNS-320
Stefan Herbrechtsmeier
stefan at herbrechtsmeier.net
Sat May 24 15:29:33 CEST 2014
Am 19.05.2014 11:21, schrieb Prafulla Wadaskar:
>> -----Original Message-----
>> From: Bastien ROUCARIÈS
>> [mailto:roucaries.bastien at gmail.com]
>> Sent: 18 May 2014 21:51
>> To: u-boot at lists.denx.de
>> Cc: Jamie Lentin; Prafulla Wadaskar; Albert ARIBAUD;
>> Stefan Herbrechtsmeier
>> Subject: [PATCH 4/4] kirkwood: Shorten DNS-325
>> IDENT_STRING to match DNS-320
>>
>> From: Jamie Lentin <jm at lentin.co.uk>
>>
>> You should already know you're using a D-link device.
>>
>> Signed-off-by: Jamie Lentin <jm at lentin.co.uk>
>>
>> Cc: Prafulla Wadaskar <prafulla at marvell.com>
>> Cc: Jamie Lentin <jm at lentin.co.uk>
>> Cc: Albert ARIBAUD <albert.u.boot at aribaud.net>
>> Cc: Stefan Herbrechtsmeier
>> <stefan at code.herbrechtsmeier.net>
>> ---
>> include/configs/dnskw.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/configs/dnskw.h
>> b/include/configs/dnskw.h
>> index e55fdc4..7058873 100644
>> --- a/include/configs/dnskw.h
>> +++ b/include/configs/dnskw.h
>> @@ -19,7 +19,7 @@
>> #ifdef CONFIG_BOARD_IS_DNS325
>> #define MACH_TYPE_DNS325 3800
>> #define CONFIG_MACH_TYPE MACH_TYPE_DNS325
>> -#define CONFIG_IDENT_STRING "\nD-Link DNS-325"
>> +#define CONFIG_IDENT_STRING "\nDNS-325"
> First of all thanks for preferring short names.
>
> Since the file is renamed to dnskw, and there are two or more boards supported like 320 and 325,
>
> Does above string makes sense? Or you should better name to some common name? like "DNSKW"?
Because the u-boot.kwb is different for the boards I would prefer
different names.
More information about the U-Boot
mailing list