[U-Boot] [U-boot] [PATCH] mtd: nand: davinci: add header file for driver definitions

Ivan Khoronzhuk ivan.khoronzhuk at ti.com
Thu May 29 18:40:52 CEST 2014


On 05/29/2014 07:13 PM, Murali Karicheri wrote:
> On 5/29/2014 11:58 AM, Ivan Khoronzhuk wrote:
>> The definitions inside emif_defs.h concern davinci nand driver and
>> should be in it's header. So create header file for davinci nand
>> driver and move definitions from emif_defs.h to it.
> Ivan,
>
> It is difficult to see what is done here. Can you rename the file in a 
> separate patch?
> Do it similar to what is done in kernel where aemif driver concerns 
> with bus configuration
> and nand drivers concerns with NAND part of the EMIF driver.

Yes, you are right.
I think there is no reason to rename it at all, as it'll be deleted in 
the following patch.
I'll hold it as is and remove it in the patch
"[U-boot] [PATCH] ARM: keystone: aemif: move aemif driver to 
drivers/memory/ti-aemif.c"

Thanks.

-- 
Regards,
Ivan Khoronzhuk



More information about the U-Boot mailing list