[U-Boot] [PATCH v2 4/4] Correct return code from builtin_run_command_list()

Simon Glass sjg at chromium.org
Fri May 30 22:41:51 CEST 2014


The return code is not consistent with cli_simple_run_command_list(). For the
last command in a sequence, the return code is actually inverted.

Fix it.
Signed-off-by: Simon Glass <sjg at chromium.org>
---

Changes in v2:
- Rebase to master

 common/cli_simple.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/cli_simple.c b/common/cli_simple.c
index 413c2eb..49d5833 100644
--- a/common/cli_simple.c
+++ b/common/cli_simple.c
@@ -331,7 +331,7 @@ int cli_simple_run_command_list(char *cmd, int flag)
 		++next;
 	}
 	if (rcode == 0 && *line)
-		rcode = (cli_simple_run_command(line, 0) >= 0);
+		rcode = (cli_simple_run_command(line, 0) < 0);
 
 	return rcode;
 }
-- 
1.9.1.423.g4596e3a



More information about the U-Boot mailing list