[U-Boot] [PATCH v5 3/4] lib, fdt: move fdtdec_get_int() out of lib/fdtdec.c

[Simon Glass]

Hi Heiko,

On 28 May 2014 03:33, Heiko Schocher <hs at denx.de> wrote:
> move fdtdec_get_int() out of lib/fdtdec.c into lib/fdtdec_common.c
> as this function is also used, if CONFIG_OF_CONTROL is not
> used. Poped up on the ids8313 board using signed FIT images,
> and activating CONFIG_SYS_GENERIC_BOARD. Without this patch
> it shows on boot:
>
> No valid FDT found - please append one to U-Boot binary, use u-boot-dtb.bin or define CONFIG_OF_EMBED. For sandbox, use -d <file.dtb>
>
> With this patch, it boots again with CONFIG_SYS_GENERIC_BOARD
> enabled.
>
> Signed-off-by: Heiko Schocher <hs at denx.de>
> Acked-by: Simon Glass <sjg at chromium.org>
> Cc: Tom Rini <trini at ti.com>

FYI I just noticed some apparent failures for this:

$ ./tools/buildman/buildman -b try-heiko3 -s
...
04: lib, fdt: move fdtdec_get_int() out of lib/fdtdec.c
     sparc: +   grsim grsim_leon2 gr_cpci_ax2000 gr_xc3s_1500 gr_ep2s60
        sh: +   ms7750se ap_sh4a_4a sh7753evb sh7763rdp r0p7734
r2dplus ms7720se shmin sh7752evb espt ap325rxa mpr2 ms7722se r7780mp
ecovec sh7785lcr sh7757lcr MigoR sh7785lcr_32bit
  blackfin: +   cm-bf561 blackstamp bf537-minotaur br4 cm-bf527
bf506f-ezkit ip04 bf527-sdp pr1 bf527-ezkit-v2 tcm-bf518 bf537-pnav
bf537-srv1 cm-bf548 bf548-ezkit bf525-ucr2 blackvme bf527-ezkit
bf518f-ezbrd bf527-ad7160-eval bf526-ezbrd
     nds32: +   adp-ag101p adp-ag102 adp-ag101

For example:

$ ./tools/buildman/buildman -b try-heiko3 -se grsim
...
04: lib, fdt: move fdtdec_get_int() out of lib/fdtdec.c
     sparc: +   grsim grsim_leon2
+lib/built-in.o: In function `fdtdec_get_int':
+/usr/local/google/c/cosarm/src/third_party/u-boot/try-heiko3/.bm-work/14/lib/fdtdec_common.c:29:
undefined reference to `fdt_getprop'
+make[1]: *** [u-boot] Error 1
+make: *** [sub-make] Error 2
+/usr/local/google/c/cosarm/src/third_party/u-boot/try-heiko3/.bm-work/19/lib/fdtdec_common.c:29:
undefined reference to `fdt_getprop'

Regards,
Simon