[U-Boot] [PATCH 12/12] sunxi: Add support for using MII phy-s with the GMAC nic

Hans de Goede hdegoede at redhat.com
Sat May 31 16:08:21 CEST 2014


Hi,

On 05/31/2014 02:13 PM, Ian Campbell wrote:
> On Sat, 2014-05-31 at 13:45 +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 05/31/2014 11:51 AM, Ian Campbell wrote:
>>> On Fri, 2014-05-30 at 15:18 +0200, Hans de Goede wrote:
>>>> Note I've added myself as board-maintainer for the cubietruck 
>>>
>>> Which patch was that? I noticed a bunch of boards.cfg which weren't
>>> described in the commit logs.
>>
>> In the "sunxi: Add axp209 pmic support" patch, where the commit logs
>> says:
>>
>> While changing the boards.cfg lines for the Cubietruck, add myself as board
>> maintainer for the Cubietruck.
> 
> Yes, I found it later. It was all the other boards.cfg changes which
> weren't mentioned in their respective logs ;-)

Right, so for v2 of this series you want me to add a line to the log
like this ? :

And enable AXP209 support on boards which have this pmic.

> 
>>>> since you did
>>>> not add yourself, feel free to submit a patch to make you the maintainer
>>>> instead if you want :)
>>>
>>> Is co-maintainership allowed?
>>
>> Looking at other boards, yes. It seems the format for co-maintainership
>> would be putting something like this in the last column:
>>
>> Hans de Goede <hdegoede at redhat.com>:Ian Campbell <ijc at hellion.org.uk>
> 
> Let's do that then, at least for the boards which we both have/want to
> support (for me that is cubieboard2 and cubietruck for the moment).

Works for me, shall I adjust things in v2 of my series to add you at
the same time I add myself for the cubietruck ?

Also please add me as co-maintainer in the cubieboard2 patch you're
working on.

> 
>> p.s.
>>
>> Any chance you could review the rest of this series ?
> 
> Yep, I just did the easy bits which fitted into the time I had available
> yesterday. I'll try and make time for the more involved bits soon.

Thanks!

Regards,

Hans


More information about the U-Boot mailing list