[U-Boot] [PATCH v3 1/5] imx: gpt: Add High frequency clock source support for GPT

Stefano Babic sbabic at denx.de
Mon Nov 3 11:23:21 CET 2014


Hi Ye,

On 30/10/2014 11:20, Ye.Li wrote:
> Introduce a new configuration "CONFIG_MXC_GPT_HCLK". When it is set,
> the GPT will select a high frequency clock as clock source.
> Otherwise, the GPT will stay to use 32Khz OSC as clock source.
> 
> In the implementation, since only the GPT on i.MX6 series provide the
> clock source option for 24Mhz OSC. For others (only i.MX5 and i.MX6
> compile the driver), if the configuration is set, the perclk will be
> selected as clock source.
> MX6Q/D Rev 1.0 and MX6SL are special in the implementation, because they
> don't have the 24Mhz OSC clock source option, so also select the perclk
> for them. For MX6SL, we will set the OSC 24Mhz to perclk in CCM, so
> eventually the clock comes from OSC 24Mhz.
> 
> Signed-off-by: Ye.Li <B37916 at freescale.com>
> ---


After fixing the following checkpatch's warnings:

CHECK: Logical continuations should be on the previous line
#119: FILE: arch/arm/imx-common/timer.c:47:
+       if (((is_cpu_type(MXC_CPU_MX6Q) || is_cpu_type(MXC_CPU_MX6D))
                        +               && (is_soc_rev(CHIP_REV_1_0) > 0))

                CHECK: Logical continuations should be on the previous line
#120: FILE: arch/arm/imx-common/timer.c:48:
                +               && (is_soc_rev(CHIP_REV_1_0) > 0))
        +               || is_cpu_type(MXC_CPU_MX6DL) ||
is_cpu_type(MXC_CPU_MX6SOLO)

        CHECK: Logical continuations should be on the previous line
#121: FILE: arch/arm/imx-common/timer.c:49:
        +               || is_cpu_type(MXC_CPU_MX6DL) ||
is_cpu_type(MXC_CPU_MX6SOLO)
        +               || is_cpu_type(MXC_CPU_MX6SX))

        CHECK: Logical continuations should be on the previous line
#178: FILE: arch/arm/imx-common/timer.c:109:
        +               if (is_cpu_type(MXC_CPU_MX6DL) ||
is_cpu_type(MXC_CPU_MX6SOLO)
                        +                       ||
is_cpu_type(MXC_CPU_MX6SX)) {

CHECK: Alignment should match open parenthesis
#183: FILE: arch/arm/imx-common/timer.c:114:
               +                        __raw_writel((7 <<
GPTPR_PRESCALER24M_SHIFT),
                               +
                &cur_gpt->prescaler);


Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list