[U-Boot] [PATCH 1/2] usb: ehci: rmobile: Add support R8A7793

Marek Vasut marex at denx.de
Tue Nov 4 09:13:10 CET 2014


On Tuesday, November 04, 2014 at 08:10:30 AM, Nobuhiro Iwamatsu wrote:
> Hi!

Hi!

[...]

> > btw. just an idea, but you don't need to explicitly use
> > usb_base_address[CONFIG_USB_MAX_CONTROLLER_COUNT], you can
> > just use usb_base_address[] in the array definition. Then,
> > in the code, you can just use "ARRAY_SIZE(usb_base_address) - 1"
> > instead of CONFIG_USB_MAX_CONTROLLER_COUNT . This rids you of
> > one annoying macro in that driver ;-) If you want to implement
> > this, then please do so, but in a separate patch.
> 
> Indeed. I will create a patch which fix your point.
> 
> > I'll pick these two patches now.
> 
> Thanks!

Thank you, I will queue it for the next PR, since I sent this one out
already.

Best regards,
Marek Vasut


More information about the U-Boot mailing list