[U-Boot] [PATCH 08/11] omap3: cm-t3517: add basic board support

[Tom Rini]

On Mon, Nov 03, 2014 at 11:32:24AM +0200, Igor Grinberg wrote:

> CompuLab cm-t3517 is Computer on Module (CoM) based on AM3517 SoC.
> Features: up to 256MB DDR2, up to 512MB NAND, USB hub, mUSB, WiFi, BT,
> Analog audio codec, touch screen controller, LED.
> 
> Add basic support including:
> LED, Serial console, NAND, MMC, GPIO, I2C, 256MB DRAM.
> 
> Signed-off-by: Igor Grinberg <grinberg at compulab.co.il>
[snip]
> +/*
> + * The early kernel mapping on ARM currently only maps from the base of DRAM
> + * to the end of the kernel image.  The kernel is loaded at DRAM base + 0x8000.
> + * The early kernel pagetable uses DRAM base + 0x4000 to DRAM base + 0x8000,
> + * so that leaves DRAM base to DRAM base + 0x4000 available.
> + */
> +#define CONFIG_SYS_BOOTMAPSZ	        0x4000

The big comment about layout at the top of
include/configs/ti_armv7_common.h applies to omap3 too, are you sure you
want to go in the direction instead?  In fact, are you sure you can't /
don't want to leverage that file?

> +#define CONFIG_SYS_BAUDRATE_TABLE	{4800, 9600, 19200, 38400, 57600,\
> +					115200}

Use the default table?

> +#define CONFIG_SYS_MEMTEST_START	(OMAP34XX_SDRC_CS0)	/* memtest */
> +								/* works on */
> +#define CONFIG_SYS_MEMTEST_END		(OMAP34XX_SDRC_CS0 + \
> +					0x01F00000) /* 31MB */

Really want this on?  See doc/README.memory-test

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141104/9a5ba3cd/attachment.pgp>