[U-Boot] [PATCH 10/39] x86: Remove unused early_board_init() call

Bin Meng bmeng.cn at gmail.com
Fri Nov 7 03:58:02 CET 2014


On Fri, Nov 7, 2014 at 4:20 AM, Simon Glass <sjg at chromium.org> wrote:
> This allows early board init before board_init_f() is called. We already
> have a standard U-Boot board call, and no boards use this, so drop it.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>  arch/x86/cpu/start.S                           |  5 -----
>  board/chromebook-x86/coreboot/Makefile         |  2 +-
>  board/chromebook-x86/coreboot/coreboot_start.S | 13 -------------
>  3 files changed, 1 insertion(+), 19 deletions(-)
>  delete mode 100644 board/chromebook-x86/coreboot/coreboot_start.S
>
> diff --git a/arch/x86/cpu/start.S b/arch/x86/cpu/start.S
> index 338bab1..62ac4cd 100644
> --- a/arch/x86/cpu/start.S
> +++ b/arch/x86/cpu/start.S
> @@ -61,11 +61,6 @@ _start:
>         /* Clear the interrupt vectors */
>         lidt    blank_idt_ptr
>
> -       /* Early platform init (setup gpio, etc ) */
> -       jmp     early_board_init
> -.globl early_board_init_ret
> -early_board_init_ret:
> -
>         /* Initialise Cache-As-RAM */
>         jmp     car_init
>  .globl car_init_ret
> diff --git a/board/chromebook-x86/coreboot/Makefile b/board/chromebook-x86/coreboot/Makefile
> index 27ebe78..071bdc4 100644
> --- a/board/chromebook-x86/coreboot/Makefile
> +++ b/board/chromebook-x86/coreboot/Makefile
> @@ -12,4 +12,4 @@
>  # SPDX-License-Identifier:     GPL-2.0+
>  #
>
> -obj-y  += coreboot_start.o coreboot.o
> +obj-y  += coreboot.o
> diff --git a/board/chromebook-x86/coreboot/coreboot_start.S b/board/chromebook-x86/coreboot/coreboot_start.S
> deleted file mode 100644
> index 932fe6c..0000000
> --- a/board/chromebook-x86/coreboot/coreboot_start.S
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -/*
> - * Copyright (c) 2011 The Chromium OS Authors.
> - * (C) Copyright 2008
> - * Graeme Russ, graeme.russ at gmail.com.
> - *
> - * SPDX-License-Identifier:    GPL-2.0+
> - */
> -
> -/* board early intialization */
> -.globl early_board_init
> -early_board_init:
> -       /* No 32-bit board specific initialisation */
> -       jmp     early_board_init_ret
> --

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>


More information about the U-Boot mailing list