[U-Boot] [PATCH 0/2] spl: MMC U-Boot image load from raw partition

Albert ARIBAUD albert.u.boot at aribaud.net
Sun Nov 9 01:12:51 CET 2014


Hello Paul,

On Sat, 08 Nov 2014 23:23:04 +0100, Paul Kocialkowski
<contact at paulk.fr> wrote:
> Le samedi 08 novembre 2014 à 23:19 +0100, Albert ARIBAUD a écrit :
> > Hello Paul,
> > 
> > On Sat,  8 Nov 2014 23:14:54 +0100, Paul Kocialkowski
> > <contact at paulk.fr> wrote:
> > > This is a first attempt at adding support for U-Boot image load
> > > from raw partitions. It does not support OS boot as I cannot test
> > > it on my current setup.
> > > 
> > > This is going to be useful for the Optimus Black port (please do
> > > not consider this as dead code because no board is using it right
> > > now, there will be one soon)!
> > 
> > Well... Why don't you just post these two patches a little later, as
> > part of the upcoming series which will add support for the Optimus
> > Black?
> 
> The honest answer here is that I don't think I'll have time to handle
> having the patches reviewed all at once and that I prefer to do things
> step by step, week after week (work on the next thing when the
> previous piece is ready or nearly so). Things are independent enough
> for this to work.

My own honest answer in turn is that potential reviewers of your code
may not think they'll have time to look at code which they cannot
assess because they don't know how it is (going to be) called.

If you feel you cannot handle reviews of the whole set all at once,
then it seems to me the problem is yours to solve: post the whole
series, let the whole review happen, and then just look at the comments
for each patch in turn at your own pace.

This way you avoid posting dead code *and* you get to handle patch
reviews piecewise as you would like.

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list