[U-Boot] [PATCH v3 4/8] imx6: add some flexibility for defining macros

[John Tobias]

Hi Stefano,

On Sun, Nov 9, 2014 at 1:24 PM, Stefano Babic <sbabic at denx.de> wrote:
>
>
> On 08/11/2014 22:27, John Tobias wrote:
>> iMX6 SabreSD has different stack address compare
>> to the default stack address defined on the file.
>>
>> The CONFIG_SYS_TEXT_BASE is defined in mx6sabre_common.h which is
>> same address defined on file. At the same time to avoid compilation
>> warnings.
>> ---
>>  include/configs/imx6_spl.h | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/include/configs/imx6_spl.h b/include/configs/imx6_spl.h
>> index 5a5f940..4ff37b3 100644
>> --- a/include/configs/imx6_spl.h
>> +++ b/include/configs/imx6_spl.h
>> @@ -29,7 +29,9 @@
>>  #define CONFIG_SPL_TEXT_BASE         0x00908000
>>  #define CONFIG_SPL_MAX_SIZE          0x10000
>>  #define CONFIG_SPL_START_S_PATH              "arch/arm/cpu/armv7"
>> +#ifndef CONFIG_SPL_STACK
>>  #define CONFIG_SPL_STACK             0x0091FFB8
>> +#endif
>
> Why is this required ?

Other iMX6 chip has different STACK address and the current defined
address does not
compatibile for the iMX6 SabreSD. The intention is to use as much as
possible the said header
and it should have the ability to change the value of it. e.g defined
in mx6sabresd.h

#ifdef CONFIG_SPL
#define CONFIG_SPL_LIBCOMMON_SUPPORT
#define CONFIG_SPL_MMC_SUPPORT
#define CONFIG_SPL_STACK 0x0093FFB8
#include "imx6_spl.h"
#endif

>
>>  #define CONFIG_SPL_LIBCOMMON_SUPPORT
>>  #define CONFIG_SPL_LIBGENERIC_SUPPORT
>>  #define CONFIG_SPL_SERIAL_SUPPORT
>> @@ -66,7 +68,9 @@
>>  #define CONFIG_SPL_BSS_MAX_SIZE              0x100000        /* 1 MB */
>>  #define CONFIG_SYS_SPL_MALLOC_START  0x18300000
>>  #define CONFIG_SYS_SPL_MALLOC_SIZE   0x3200000       /* 50 MB */
>> +#ifndef CONFIG_SYS_TEXT_BASE
>>  #define CONFIG_SYS_TEXT_BASE         0x17800000
>>  #endif
>> +#endif
>>
>
> Why is this required ?

mentioned above.

Addition to that, on my recent submission for iMX6SL. It requires to
change the value of the following:

CONFIG_SPL_BSS_START_ADDR
CONFIG_SYS_SPL_MALLOC_START


Regards,

john



>
> Best regards,
> Stefano Babic
>
> --
> =====================================================================
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
> =====================================================================