[U-Boot] [PATCH 31/39] x86: ivybridge: Check BIST value on boot

Bin Meng bmeng.cn at gmail.com
Mon Nov 10 03:50:27 CET 2014


Hi Simon,

On Fri, Nov 7, 2014 at 4:20 AM, Simon Glass <sjg at chromium.org> wrote:
> The built-in self test value should be checked before we continue booting.
> Refuse to continue if there is something wrong.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>  arch/x86/cpu/ivybridge/cpu.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/arch/x86/cpu/ivybridge/cpu.c b/arch/x86/cpu/ivybridge/cpu.c
> index aa825c7..e73ccb7 100644
> --- a/arch/x86/cpu/ivybridge/cpu.c
> +++ b/arch/x86/cpu/ivybridge/cpu.c
> @@ -177,10 +177,26 @@ int arch_cpu_init(void)
>         return 0;
>  }
>
> +static int report_bist_failure(void)
> +{
> +       if (gd->arch.bist != 0) {
> +               printf("BIST failed: %08x\n", gd->arch.bist);
> +               return -EFAULT;
> +       }
> +
> +       return 0;
> +}
> +
>  int print_cpuinfo(void)
>  {

I don't see patch that moves print_cpuinfo() from arch/x86/cpu/cpu.c
to this. Is there anything I missed?

[snip]

Regards,
Bin


More information about the U-Boot mailing list