[U-Boot] [PATCH v2 1/4] x86: Do CPU identification in the early phase

[Simon Glass]

Hi Bin,

On 9 November 2014 07:18, Bin Meng <bmeng.cn at gmail.com> wrote:
> The CPU identification happens in x86_cpu_init_f() and corresponding
> fields are saved in the global data for later use.
>
> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> ---
> Changes for v2:
>   - Update the patch per review comments from Simon Glass
>   - cpu_vendor_name() and fill_processor_name() are not static now
>
>  arch/x86/cpu/cpu.c                 | 277 +++++++++++++++++++++++++++++++------
>  arch/x86/include/asm/cpu.h         | 168 +++++++++++++++++++++-
>  arch/x86/include/asm/global_data.h |   5 +
>  3 files changed, 402 insertions(+), 48 deletions(-)

Applied to u-boot-x86/master, thanks!

Note I had to clean up style problems in these patches. I decided to
do this instead of asking for a respin since I didn't check it for
version 1.

$ patman -nm -c4
Cleaned 4 patches
8 errors, 8 warnings, 2 checks for
0001-x86-Do-CPU-identification-in-the-early-phase.patch:
error: arch/x86/cpu/cpu.c,57: code indent should use tabs where possible
warning: arch/x86/cpu/cpu.c,57: please, no spaces at the start of a line
error: arch/x86/cpu/cpu.c,58: code indent should use tabs where possible
warning: arch/x86/cpu/cpu.c,58: please, no spaces at the start of a line
error: arch/x86/cpu/cpu.c,59: code indent should use tabs where possible
warning: arch/x86/cpu/cpu.c,59: please, no spaces at the start of a line
error: arch/x86/cpu/cpu.c,60: code indent should use tabs where possible
warning: arch/x86/cpu/cpu.c,60: please, no spaces at the start of a line
warning: arch/x86/cpu/cpu.c,84: static const char * array should
probably be static const char * const
error: arch/x86/cpu/cpu.c,213: space prohibited before that close
parenthesis ')'
warning: arch/x86/cpu/cpu.c,245: braces {} are not necessary for any
arm of this statement
warning: arch/x86/cpu/cpu.c,255: braces {} are not necessary for
single statement blocks
error: arch/x86/cpu/cpu.c,269: else should follow close brace '}'
error: arch/x86/cpu/cpu.c,275: space required before the open parenthesis '('
error: arch/x86/cpu/cpu.c,490: that open brace { should be on the previous line
check: arch/x86/cpu/cpu.c,491: Alignment should match open parenthesis
warning: arch/x86/cpu/cpu.c,527: line over 80 characters
check: arch/x86/cpu/cpu.c,528: Alignment should match open parenthesis

0 errors, 0 warnings, 2 checks for
0002-x86-Do-TSC-MSR-calibration-only-for-known-supported-.patch:
check: arch/x86/lib/tsc_timer.c,62: Alignment should match open parenthesis
check: arch/x86/lib/tsc_timer.c,105: Alignment should match open parenthesis

0 errors, 1 warnings, 0 checks for
0003-x86-Add-quick-TSC-calibration-via-PIT.patch:
warning: arch/x86/lib/tsc_timer.c,162: line over 80 characters


Please can you make sure you submit them with patman so that these
problems are checked?

Regards,
Simon