[U-Boot] [PATCH v6 0/3] Adds support for Exynos5422 odroid xu3 board

[Hyungwon Hwang]

Dear Minkyu Kang,

On Tue, 11 Nov 2014 21:53:35 +0900
Minkyu Kang <promsoft at gmail.com> wrote:

> On 10 November 2014 10:41, Hyungwon Hwang <human.hwang at samsung.com> wrote:
> 
> > This is v6 of the patchset adding support Odroud XU3 board.
> >
> > link to the previous version:
> > v2: https://www.mail-archive.com/u-boot@lists.denx.de/msg152275.html
> > v3: https://www.mail-archive.com/u-boot%40lists.denx.de/msg152677.html
> > v4: https://patchwork.ozlabs.org/patch/407411/
> > v5: https://patchwork.ozlabs.org/patch/407941/
> >
> > This patchset fixes GPIO information of Exynos5420 which is needed to
> > support Exynos5422 Odroid XU3 board. On the base of the fixes, this
> > patchset adds support for Exynos5422 Odroid XU3 board. I have done this
> > work on the master branch in http://git.denx.de/u-boot-samsung.git (sha1:
> > 26f195c71252e98aebfffd5cfa994a4475559370) with patches by Akshay Saraswat.
> >
> > link: https://patchwork.ozlabs.org/patch/405246/ (updated)
> >
> > How to test this patch:
> > 1. git clone http://git.denx.de/u-boot-samsung.git
> > 2. git reset --hard 26f195c71252e98aebfffd5cfa994a4475559370
> > 3. Get and apply the patchset of Akshay Saraswat
> >         https://patchwork.ozlabs.org/patch/405246/
> >         https://patchwork.ozlabs.org/patch/405247/
> >         https://patchwork.ozlabs.org/patch/405248/
> >         https://patchwork.ozlabs.org/patch/405249/
> >         https://patchwork.ozlabs.org/patch/405250/
> >         https://patchwork.ozlabs.org/patch/405251/
> >         https://patchwork.ozlabs.org/patch/405252/
> > 4. Apply this patchset
> > 5. make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- odroid-xu3_config
> > 6. make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- -j8
> > 7. Now you can use u-boot-dtb.bin for your downloading
> >
> > Note: If you use micro SD card for your test you have to apply the below
> > patch additionally. This patch is needed, because micro sd card is
> > recognized as MMC1 instead of MMC0. Additional work is needed to make it
> > work regardless of device id.
> >
> > diff --git a/include/configs/exynos5-common.h
> > b/include/configs/exynos5-common.h
> > index ba591e7..437eaae 100644
> > --- a/include/configs/exynos5-common.h
> > +++ b/include/configs/exynos5-common.h
> > @@ -109,7 +109,7 @@
> >
> >  #define CONFIG_SYS_MONITOR_BASE        0x00000000
> >
> > -#define CONFIG_SYS_MMC_ENV_DEV         0
> > +#define CONFIG_SYS_MMC_ENV_DEV         1
> >
> >  #define CONFIG_SECURE_BL1_ONLY
> >
> > diff --git a/include/configs/odroid_xu3.h b/include/configs/odroid_xu3.h
> > index cda4f26..b46ccad 100644
> > --- a/include/configs/odroid_xu3.h
> > +++ b/include/configs/odroid_xu3.h
> > @@ -110,15 +110,15 @@
> >                 "run kernel_args;" \
> >                 "bootz ${kerneladdr} ${initrd_addr} ${fdt_addr};\0" \
> >         "autoboot=" \
> > -               "if test -e mmc 0 Image.itb; then; " \
> > +               "if test -e mmc 1 Image.itb; then; " \
> >                         "run boot_fit;" \
> > -               "elif test -e mmc 0 zImage; then; " \
> > +               "elif test -e mmc 1 zImage; then; " \
> >                         "run boot_zimg;" \
> > -               "elif test -e mmc 0 uImage; then; " \
> > +               "elif test -e mmc 1 uImage; then; " \
> >                         "run boot_uimg;" \
> >                 "fi;\0" \
> >         "console=" CONFIG_DEFAULT_CONSOLE \
> > -       "mmcbootdev=0\0" \
> > +       "mmcbootdev=1\0" \
> >         "mmcbootpart=1\0" \
> >         "mmcrootdev=0\0" \
> >         "mmcrootpart=2\0" \
> >
> 
> I think you can make it selectable as env value.
> How you think?
> 

We can use ${mmcbootdev} to select the boot media simply with small changes.
But the problem is in CONFIG_SYS_MMC_ENV_DEV. Even though we can change the
bootable media through ${mmcbootdev}, we cannot save this environment to MMC
or SD card, and have to set the variable again after reboot. So I think that
this should be solved in another way.

> Thanks,
> Minkyu Kang.

Best regards,
Hyungwon Hwang

-- 
Hyungwon Hwang
S/W Platform Team, Software Center
Samsung Electronics
human.hwang at samsung.com