[U-Boot] [PATCH v3 01/14] arm: spl: Avoid setting up a duplicate global data structure

Albert ARIBAUD albert.u.boot at aribaud.net
Thu Nov 13 12:31:52 CET 2014


Hello Simon,

On Mon, 10 Nov 2014 17:16:41 -0700, Simon Glass <sjg at chromium.org> wrote:
> This is already set up in crt0.S. We don't need a new structure and don't
> really want one in the 'data' section of the image, since it will be empty
> and crt0.S's changes will be ignored.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> 
> Changes in v3: None
> Changes in v2: None
> 
>  arch/arm/lib/spl.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/arm/lib/spl.c b/arch/arm/lib/spl.c
> index 75ab546..6361a62 100644
> --- a/arch/arm/lib/spl.c
> +++ b/arch/arm/lib/spl.c
> @@ -13,10 +13,6 @@
>  #include <image.h>
>  #include <linux/compiler.h>
>  
> -/* Pointer to as well as the global data structure for SPL */
> -DECLARE_GLOBAL_DATA_PTR;
> -gd_t gdata __attribute__ ((section(".data")));
> -
>  /*
>   * In the context of SPL, board_init_f must ensure that any clocks/etc for
>   * DDR are enabled, ensure that the stack pointer is valid, clear the BSS
> -- 
> 2.1.0.rc2.206.gedb03e5
> 

Acked-by: Albert ARIBAUD <albert.u.boot at aribaud.net>

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list