[U-Boot] [PATCH] arm: mx6: Fix missing Kconfig option for Novena

[Masahiro Yamada]

Hi Marek,
(ccing Tom)

I posted a patch a week ago to fix this and some other boards
http://patchwork.ozlabs.org/patch/407286/
but it looks like Tom has not checked this bug fix patch.

My patch is intended to go directly to Tom's repo, whereas
I guess yours is going to u-boot-imx repo.

I don't think it is a good idea to fix one problem by two patches in two places.

Unfortunately, both are imperfect.

The board/kosagi/novena/Kconfig fix is missing from yours and
"select SUPPORT_SPL" is missing from mine.

So, how shall we sort out this?


Would you send v2 dropping redudant lines from board/kosagi/novena/Kconfig
and shall I send v3 omitting Kosagi stuff?


Best Regards
Masahiro Yamada







On Thu, 13 Nov 2014 11:06:21 +0100
Marek Vasut <marex at denx.de> wrote:

> Add two missing Kconfig options for Novena and drop the SPL
> from the Novena config.
> 
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Stefano Babic <sbabic at denx.de>
> Cc: Sean Cross <xobs at kosagi.com>
> Cc: Marek Vasut <marex at denx.de>
> Cc: Fabio Estevam <fabio.estevam at freescale.com>
> ---
>  arch/arm/Kconfig         | 2 ++
>  configs/novena_defconfig | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 22eb2d5..5cd621a 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -629,6 +629,8 @@ config TARGET_HUMMINGBOARD
>  
>  config TARGET_KOSAGI_NOVENA
>  	bool "Support Kosagi Novena"
> +	select CPU_V7
> +	select SUPPORT_SPL
>  
>  config TARGET_TQMA6
>  	bool "TQ Systems TQMa6 board"
> diff --git a/configs/novena_defconfig b/configs/novena_defconfig
> index a560afb..cadf461 100644
> --- a/configs/novena_defconfig
> +++ b/configs/novena_defconfig
> @@ -1,4 +1,4 @@
>  CONFIG_SPL=y
> -CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/kosagi/novena/setup.cfg,MX6Q,SPL"
> +CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/kosagi/novena/setup.cfg,MX6Q"
>  +S:CONFIG_ARM=y
>  +S:CONFIG_TARGET_KOSAGI_NOVENA=y
> -- 
> 2.0.0
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot