[U-Boot] arm: socfpga: set skew settings for ethernet phy

[Wolfgang Denk]

Dear Pavel Machek,

In message <20141113120956.GB30779 at amd> you wrote:
> 
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index 507b9a3..06a31b0 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -112,17 +112,46 @@ static int ksz9021_phy_extwrite(struct phy_device *phydev, int addr,
>  	return ksz9021_phy_extended_write(phydev, regnum, val);
>  }
>  
> +
> +

Please don't add excessive white space / blank lines.

> +	printf("ksz9021: configuring\n");
> +
> +	printf("Configuring PHY skew timing for %s\n",
> +	       phydev->drv->name);

Should these eventually be changed into debug() ?

Output gets really noisy otherwise.

>  	if (getenv("disable_giga"))

Should we not rather use the standard "hwconf" approach here?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There is a time in the tides of men, Which, taken at its flood, leads
on to success. On the other hand, don't count on it.   - T. K. Lawson