[U-Boot] [PATCH v7 4/5] imx6: add spl in the header file

[John Tobias]

Hi Stefano,

On Thu, Nov 13, 2014 at 4:49 AM, Fabio Estevam <festevam at gmail.com> wrote:
> On Thu, Nov 13, 2014 at 10:41 AM, Fabio Estevam <festevam at gmail.com> wrote:
>> Hi John,
>>
>> On Thu, Nov 13, 2014 at 6:58 AM, Stefano Babic <sbabic at denx.de> wrote:
>>
>>>>  #define CONFIG_LOADADDR                        0x12000000
>>>> +#ifndef CONFIG_SYS_TEXT_BASE
>>>>  #define CONFIG_SYS_TEXT_BASE           0x17800000
>>>> +#endif
>>>>
>>>
>>> Why is that needed ? SPL does not use it, because it use
>>> CONFIG_SPL_TEXT_BASE, and this is defined in imx6_spl.h. And you do not
>>> redefine it, meaning that overwriting the value is not necessary at all,
>>> as we expect.

The CONFIG_SYS_TEXT_BASE was defined in imx6_spl.h and I was seeing
previously some warning related to the duplication of the said macro.

I thought it would be great to remove the warning messages so that is why
I added the macro.

Regards,

john


>>
>> Stefano is right.
>>
>> You can simply remove this piece:
>>
>> --- a/include/configs/mx6sabre_common.h
>> +++ b/include/configs/mx6sabre_common.h
>> @@ -95,9 +95,6 @@
>>  #define CONFIG_BOOTDELAY               1
>>
>>  #define CONFIG_LOADADDR                        0x12000000
>> -#ifndef CONFIG_SYS_TEXT_BASE
>> -#define CONFIG_SYS_TEXT_BASE           0x17800000
>> -#endif
>
> Sorry, I meant to remove only the ifdef:
>
> --- a/include/configs/mx6sabre_common.h
> +++ b/include/configs/mx6sabre_common.h
> @@ -95,9 +95,7 @@
>  #define CONFIG_BOOTDELAY               1
>
>  #define CONFIG_LOADADDR                        0x12000000
> -#ifndef CONFIG_SYS_TEXT_BASE
>  #define CONFIG_SYS_TEXT_BASE           0x17800000
> -#endif