[U-Boot] [PATCH] x86: Fix a warning with gcc 4.4.4

[Simon Glass]

Hi,

On 13 November 2014 02:38, Bin Meng <bmeng.cn at gmail.com> wrote:
> On Thu, Nov 13, 2014 at 5:00 PM, Måns Rullgård <mans at mansr.com> wrote:
>> Simon Glass <sjg at chromium.org> writes:
>>
>>> This warning appears even though it seems that the compiler could work it
>>> out. Fix it.
>>>
>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>> ---
>>>
>>>  arch/x86/cpu/cpu.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/x86/cpu/cpu.c b/arch/x86/cpu/cpu.c
>>> index a4e639d..3583619 100644
>>> --- a/arch/x86/cpu/cpu.c
>>> +++ b/arch/x86/cpu/cpu.c
>>> @@ -238,6 +238,7 @@ static void identify_cpu(struct cpu_device_id *cpu)
>>>       int i;
>>>
>>>       vendor_name[0] = '\0'; /* Unset */
>>> +     cpu->device = 0; /* fix gcc 4.4.4 warning */
>>>
>>>       /* Find the id and vendor_name */
>>>       if (!has_cpuid()) {
>>> --
>>
>> Do other gcc versions warn as well?  4.4 is old and worse than both 4.3
>> and 4.5 in many ways, so there's very little reason to be using it.  If
>> more sensible gcc versions do not warn, it's better leaving it as is to
>> avoid real errors creeping in unnoticed.
>>

That gcc is only 5 years old and this is the only such problem in
U-Boot so I'd like to fix it.

>> --
>
> I am using 4.7.2 which does not generate this warning.

4.8.2 doesn't either.

Regards,
Simon