[U-Boot] [PATCH v2 6/7] board: iocon: Fix uninitialized access

dirk.eibach at gdsys.cc dirk.eibach at gdsys.cc
Thu Nov 13 19:21:17 CET 2014


From: Dirk Eibach <dirk.eibach at gdsys.cc>

Wolfgang Denk found this issue using cppcheck:
(error) Uninitialized variable: fpga_features

Signed-off-by: Dirk Eibach <dirk.eibach at gdsys.cc>
---

Changes in v2:
- fix cppcheck finding reported by Wolfgang

 board/gdsys/405ep/iocon.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/board/gdsys/405ep/iocon.c b/board/gdsys/405ep/iocon.c
index fffed73..1d7e141 100644
--- a/board/gdsys/405ep/iocon.c
+++ b/board/gdsys/405ep/iocon.c
@@ -369,10 +369,11 @@ int last_stage_init(void)
 	unsigned char mclink_controllers[] = { 0x24, 0x25, 0x26 };
 	int legacy = get_fpga_state(0) & FPGA_STATE_PLATFORM;
 	u16 fpga_features;
-	int feature_carrier_speed = fpga_features & (1<<4);
+	int feature_carrier_speed;
 	bool ch0_rgmii2_present = false;
 
 	FPGA_GET_REG(0, fpga_features, &fpga_features);
+	feature_carrier_speed = fpga_features & (1<<4);
 
 	if (!legacy) {
 		/* Turn on Parade DP501 */
-- 
1.8.3



More information about the U-Boot mailing list