[U-Boot] [PATCH v2] tools/kwbimage: Fix compilation warning

York Sun yorksun at freescale.com
Thu Nov 13 23:51:55 CET 2014


On 10/28/2014 03:38 AM, Wolfgang Denk wrote:
> Dear Stefan Roese,
> 
> In message <1414492344-19055-1-git-send-email-sr at denx.de> you wrote:
>> This patch fixes a compilation warning of kwbimage.c:
>>
>> tools/kwbimage.c: In function ‘kwbimage_set_header’:
>> tools/kwbimage.c:784:8: warning: ‘headersz’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>>   memcpy(ptr, image, headersz);
>>         ^
>> Instead of using multiple if statements, use a switch statement with
>> a default entry. And return with error if an unsupported version
>> is configured in the cfg file.
>>
>> Signed-off-by: Stefan Roese <sr at denx.de>
>> ---
>> v2:
>> - Change error message so that it really makes sense (unsupported
>>   version instead of no version)
>> - Change this also in the commit text
>> - Small change (s/is/if)
> 
> Acked-By: Wolfgang Denk <wd at denx.de>
> 

I failed to see how the warning message got fixed. I still see this warning when
compiling.

York




More information about the U-Boot mailing list