[U-Boot] putc

[Simon Glass]

Hi Wolfgang,

On 13 November 2014 13:51, Wolfgang Denk <wd at denx.de> wrote:
> Dear Simon,
>
> In message <CAPnjgZ1hKpGUCqU8D36VXm14jg_Xv=Q1qUh+kpnamJX6834_Yg at mail.gmail.com> you wrote:
>>
>> > Adding a parameter to these exported functions will break backward
>> > compatibility
>> > of existing standalone apps
>>
>> Yes that's right, but when they move to a newer U-Boot they will need
>> to be updated. Isn't that expected with standalone apps? I can adjust
>> things that are in the mainline tree, but I can't fix up people's
>> third party apps.
>
> Backard compatibility has never been an issue with SA applications.
> The design intentionally introduced the XF_VERSION number (see
> include/exports.h) which just has to be incremented to signalize
> interface changes.
>
> But then, putc() is a stdio function with well-known synopsis, and
> this should never be changed.

Unfortunately, I changed it, but for good reason I think.

>
>> I did make a suggestion about how to avoid adding the extra parameter
>> (changing the behaviour to call putc() instead of dev->putc()). What
>> do you think?
>
> Sounds better to me.

OK. I also feel that the void *[] type is asking for trouble. I'll see
if I can do a patch to change putc() and a few others.

Regards,
Simon