[U-Boot] [PATCH v2] arm: socfpga: set skew settings for ethernet phy

[Marek Vasut]

On Saturday, November 15, 2014 at 08:54:06 PM, Pavel Machek wrote:
> On Fri 2014-11-14 21:02:48, Marek Vasut wrote:
> > On Friday, November 14, 2014 at 11:23:27 AM, Pavel Machek wrote:
> > > On Thu 2014-11-13 11:23:41, dinguyen at opensource.altera.com wrote:
> > > > From: Dinh Nguyen <dinguyen at opensource.altera.com>
> > > > 
> > > > Set the PHY skew settings for the ethernet phy on the SOCFPGA
> > > > Cyclone5 hardware.
> > > 
> > > Is it to need similar settings for all ksz9021 phys? Should this go to
> > > drivers/ as I suggested with a patch?
> > 
> > This is board specific, but with the driver model, this should be moved
> > into the PHY driver and the values should be passed via platform data or
> > DT.
> > 
> > I will apply this now, since it fixes real issue.
> 
> Hmm, could you apply the patch I posted, instead? It has configuration
> in socfpga_config.h -- "platform data".

Hi!

The patch you provided (if we're referring to the same patch, Message-ID: 
<20141113120956.GB30779 at amd>) breaks every board which uses the Micrel PHY, 
doesn't it ? The problem for all other boards would be the new CONFIG_* options
which are added into the Micrel driver by that patch. Furthermore, the patch 
doesn't even apply, it was decided that the patch was an RFC, wasn't it ?
Please correct me if I'm wrong.

The way forward here would be for you to prepare a patch for the Micrel PHY
driver, submit that one (make sure to CC Joe, the network custodian) and
in the next step clean up the writes into PHY configuration from both the
SoCFPGA CV and from Nitrogen 6x support (I recall I saw the same thing done
for that board).

Oh, and btw., the new CONFIG_* options should be documented somewhere, so
please keep that in mind. Otherwise, the amount of various CONFIG_* options
become an unmanagable mess.

Thanks!

Best regards,
Marek Vasut