[U-Boot] [PATCH 2/5] arm: socfpga: Use only one clrbits_le32 call to deassert SPI reset bits

Pavel Machek pavel at denx.de
Mon Nov 17 08:54:56 CET 2014


On Sun 2014-11-16 12:46:59, Stefan Roese wrote:
> As suggested by Pavel, lets combine the two calls into one.
> 
> Signed-off-by: Stefan Roese <sr at denx.de>
> Cc: Chin Liang See <clsee at altera.com>
> Cc: Dinh Nguyen <dinguyen at altera.com>
> Cc: Vince Bridgers <vbridger at altera.com>
> Cc: Marek Vasut <marex at denx.de>

Acked-by: Pavel Machek <pavel at denx.de>

> ---
>  arch/arm/cpu/armv7/socfpga/reset_manager.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/cpu/armv7/socfpga/reset_manager.c b/arch/arm/cpu/armv7/socfpga/reset_manager.c
> index af9db85..25921e7 100644
> --- a/arch/arm/cpu/armv7/socfpga/reset_manager.c
> +++ b/arch/arm/cpu/armv7/socfpga/reset_manager.c
> @@ -110,6 +110,6 @@ void socfpga_spim_enable(void)
>  {
>  	const void *reset = &reset_manager_base->per_mod_reset;
>  
> -	clrbits_le32(reset, 1 << RSTMGR_PERMODRST_SPIM0_LSB);
> -	clrbits_le32(reset, 1 << RSTMGR_PERMODRST_SPIM1_LSB);
> +	clrbits_le32(reset, (1 << RSTMGR_PERMODRST_SPIM0_LSB) |
> +		     (1 << RSTMGR_PERMODRST_SPIM1_LSB));
>  }

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


More information about the U-Boot mailing list