[U-Boot] [PATCH v8 0/6] fs: fat/ext4/sandbox - Deal with files greater than 2GB

Suriyan Ramasami suriyan.r at gmail.com
Mon Nov 17 23:39:33 CET 2014


The commands fatls/ext4ls give negative values when dealing with files
greater than 2GB.
The commands fatsize/ext4size do not update the variable filesize for
these files.

To deal with this, the fs functions have been modified to take an additional
parameter of type "* loff_t" which is then populated. The return value of th
fs functions are used only for error conditions.

Changes in v8:
- No changes.
- Simon - indentation fixes
- None
- Simon, use variable size consistently across all changes.
- (Simon) ext4_read_file(), return ext4fs_read() at end
- (Simon) remove braces around if statement, if there is only one statement

Changes in v7:
- Add Ack
- Separate this patch out
- Split this patch for bisectability.
- Simon, split this as a separate commit
- (Pavel) U_BOOT_CMD save to reflect mandatory arguments
- (Simon) Split this into a separate patch
- Simon comments
- take care of fat/vfat in mkfs
- fs/nonfs test code repeats, put it in function

Changes in v6:
- Split this change into a separate commit
- Update expected results in comments
- Simon comments
-  Remove README file and add it in start of script
-  Drop blank lines in top of functions
-  Put repeating constants in lower case variables
-  Refer to U-Boot as U-Boot
-  Move settings to top of file and code in functions or otherwise at bottom
-  Create check_prereq function
-  Use mkfs -t <type> -F <img> for ext4, but modify for fat

Changes in v5:
- Simon comments
-   Add README file to document how to run it
-   Generate output in a sandbox environment
-   Add one line comments on shell variables used
-   Avoid camel case through out
-   Path to UBOOT is variable at top
-   Print PASSED or FAILED at end, and set return code, 0 if OK, 1 otherwise

Suriyan Ramasami (6):
  sandbox: Use md5sum and fatwrite to enable testing of fs commands
  fat: Prepare API change for files greater than 2GB
  ext4: Prepare API change for files greater than 2GB
  sandbox: Prepare API change for files greater than 2GB
  fs: API changes enabling extra parameter to return size of type loff_t
  sandbox: script for testing sandbox/ext4/fat/fs commands

 arch/sandbox/cpu/os.c     |  13 +-
 arch/sandbox/cpu/state.c  |   8 +-
 common/board_f.c          |   8 +-
 common/cmd_ext4.c         |  61 +----
 common/cmd_fat.c          |   9 +-
 common/cmd_fs.c           |  17 ++
 common/cmd_md5sum.c       |  12 +-
 common/env_fat.c          |   4 +-
 fs/ext4/ext4_common.c     |  24 +-
 fs/ext4/ext4_common.h     |   4 +-
 fs/ext4/ext4_write.c      |  32 +++
 fs/ext4/ext4fs.c          |  37 +--
 fs/fat/fat.c              | 130 ++++++-----
 fs/fat/fat_write.c        |  61 ++---
 fs/fat/file.c             |   3 +-
 fs/fs.c                   |  77 ++++---
 fs/sandbox/sandboxfs.c    |  77 ++++---
 include/configs/sandbox.h |   2 +
 include/ext4fs.h          |  13 +-
 include/fat.h             |  18 +-
 include/fs.h              |  41 ++--
 include/os.h              |   5 +-
 include/sandboxfs.h       |  14 +-
 test/fs/fs-test.sh        | 561 ++++++++++++++++++++++++++++++++++++++++++++++
 24 files changed, 943 insertions(+), 288 deletions(-)
 create mode 100755 test/fs/fs-test.sh

-- 
1.8.3.1



More information about the U-Boot mailing list