[U-Boot] [PATCH 0/6] ARM: at91: SAMA5: extract the common sama5 chip configurations to a common header

[Josh Wu]

Hi, Bo

On 11/20/2014 9:12 AM, Bo Shen wrote:
> Hi Josh,
>
> On 11/19/2014 07:02 PM, Josh Wu wrote:
>> This patch series reorganized the configurations for SAMA5 chips.
>> Make the common part into one file.
>> That way we don't need to have many copy of the same configurations.
>
> Thanks for this patch.
> However, the u-boot is switching to Kconfig, so in the following time, 
> the configuration option will move to Kconfig. So I think now we keep 
> it as is.
>
yes, I understand we'll switch to Kconfig. But the better way is switch 
to Kconfig step by step.
So I think it is a good start to extract the common part of the 
configuration to one file.
Next step, we can move the common part of configuration to the Kconfig.
And other different configuration to the _defconfig.

> I think at this phase, we can move the configuration in header file to 
> Kconfig, maybe this is a good choice.
Like I said in above, I prefer to do this step by step. So what do you 
think?

Best Regards,
Josh Wu

>
>> Josh Wu (6):
>>    ARM: at91: sama5d3_xplained: spl: enable PMECC header generation
>>    ARM: at91: sama5: move the common part of configurations to
>>      at91-sama5_common.h
>>    ARM: at91: sama5d3_xplained: set ENV_FAT_DEVICE_AND_PART intead of
>>      using number
>>    ARM: at91: sama5d3: mmc: save enviroment as a fat file (uboot.env)
>>    ARM: at91: sama5: move the bootcmd definition to the common header
>>    ARM: at91: at91sam9x5: mmc: save environment as a file in FAT
>>      partition.
>>
>>   include/configs/at91-sama5_common.h | 126 
>> ++++++++++++++++++++++++++++++++++++
>>   include/configs/at91sam9x5ek.h      |  12 ++--
>>   include/configs/sama5d3_xplained.h  | 100 ++--------------------------
>>   include/configs/sama5d3xek.h        | 114 
>> ++------------------------------
>>   include/configs/sama5d4_xplained.h  | 116 
>> ++-------------------------------
>>   include/configs/sama5d4ek.h         | 116 
>> ++-------------------------------
>>   6 files changed, 153 insertions(+), 431 deletions(-)
>>   create mode 100644 include/configs/at91-sama5_common.h
>>
>
> Best Regards,
> Bo Shen