[U-Boot] [PATCH] arm: make arch memset/memcpy to work with Thumb2 builds

Jeroen Hofstee jeroen at myspectrum.nl
Thu Nov 20 16:53:33 CET 2014


Hi,

On 20-11-14 16:18, Bill Pringlemeir wrote:
>
>> ---
>> arch/arm/lib/memset.S | 40 ++++++++++++++++++++--------------------
>> 1 file changed, 20 insertions(+), 20 deletions(-)
>>
>> diff --git a/arch/arm/lib/memset.S b/arch/arm/lib/memset.S
>> index 0cdf895..4fe38f6 100644
>> --- a/arch/arm/lib/memset.S
>> +++ b/arch/arm/lib/memset.S
>> @@ -18,8 +18,8 @@
>> 1:	subs	r2, r2, #4		@ 1 do we have enough
>> 	blt	5f			@ 1 bytes to align with?
>> 	cmp	r3, #2			@ 1
>> -	strltb	r1, [r0], #1		@ 1
>> -	strleb	r1, [r0], #1		@ 1
>> +	strblt	r1, [r0], #1		@ 1
>> +	strble	r1, [r0], #1		@ 1
> To test this, can we just use 'objdump'.  The hex codes should be
> identical; there is only one encoding.  It should produce the same
> binaries.  No need to run test-suites, etc.
>

yes, I should be trivial to test (and find the trivial problem, with
the patch I attached). I am wondering though if all version of
gas accept the suffix notation... any idea?

Regards,
Jeroen


More information about the U-Boot mailing list