[U-Boot] [PATCH 1/2] exynos5420: fix compilation without parade video

[Ajay kumar]

On Mon, Nov 24, 2014 at 8:45 PM, Sjoerd Simons
<sjoerd.simons at collabora.co.uk> wrote:
> Not all exynos 5420 based devices with an LCD also have a parade LVDS
> bridge. So make sure compilation doesn't break if CONFIG_LCD is enabled
> and CONFIG_VIDEO_PARADE is not.
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons at collabora.co.uk>
> ---
>  board/samsung/smdk5420/smdk5420.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/board/samsung/smdk5420/smdk5420.c b/board/samsung/smdk5420/smdk5420.c
> index a691222..f8be401 100644
> --- a/board/samsung/smdk5420/smdk5420.c
> +++ b/board/samsung/smdk5420/smdk5420.c
> @@ -43,6 +43,7 @@ int exynos_init(void)
>  }
>
>  #ifdef CONFIG_LCD
> +#ifdef CONFIG_VIDEO_PARADE
I think this is unnecessary.

>  static int has_edp_bridge(void)
>  {
>         int node;
> @@ -56,6 +57,7 @@ static int has_edp_bridge(void)
>         /* Default is with bridge ic */
>         return 1;
>  }
> +#endif
>
>  void exynos_lcd_power_on(void)
>  {
> @@ -83,9 +85,11 @@ void exynos_lcd_power_on(void)
>         gpio_direction_input(EXYNOS5420_GPIO_X26);      /* EDP_HPD */
>         gpio_set_pull(EXYNOS5420_GPIO_X26, S5P_GPIO_PULL_NONE);
>
> +#ifdef CONFIG_VIDEO_PARADE
How about moving this to some header and modify it like below:
#ifdef CONFIG_VIDEO_PARADE
         int parade_init(const void *blob);
#else
         static inline int parade_init(const void *blob)
         {
                   return 0;
         }
#endif

>         if (has_edp_bridge())
>                 if (parade_init(gd->fdt_blob))
>                         printf("%s: ps8625_init() failed\n", __func__);
> +#endif
>  }
>
>  void exynos_backlight_on(unsigned int onoff)
> --
> 2.1.3
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot