On Mon, 2014-11-24 at 17:14 +0100, Hans de Goede wrote: > This can be overriden through the hdmi_mode env. > variable. Apart from the question regarding the variable name I asked on "sunxi: video: Add extra modes and allow selecting the mode via hdmi_mode env" the code here looks fine to me.