[U-Boot] [PATCH v2 1/5] sun6i: Make dram clk and zq value Kconfig options

[Hans de Goede]

Hi,

On 11/25/2014 09:55 AM, Ian Campbell wrote:
> On Sun, 2014-11-23 at 14:43 +0100, Hans de Goede wrote:
>> It turns out that there is a too large spread between boards to handle this
>> with a default value, turn this into Kconfig options, and set the values
>> the factory images are using for the Colombus and Mele_M9 boards.
>>
>> Note this changes the ZQ default when not overriden through defconfig from
>> 120 to 123, as that is what most boards seem to actually use.
>>
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>
> Acked-by: Ian Campbell <ijc at hellion.org.uk>
>
> With one minor query:
>
>> +config DRAM_CLK
>> +	int "sun6i dram clock speed"
>> +	default 312
>> +	---help---
>> +	Set the dram clock speed, valid range 240 - 480, must be a multiple
>> +	of 24.
>> [...]
>> diff --git a/configs/Mele_M9_defconfig b/configs/Mele_M9_defconfig
>> index 40eabce..740b931 100644
>> --- a/configs/Mele_M9_defconfig
>> +++ b/configs/Mele_M9_defconfig
>> @@ -5,6 +5,8 @@ CONFIG_FDTFILE="sun6i-a31-m9.dtb"
>>   +S:CONFIG_ARCH_SUNXI=y
>>   +S:CONFIG_MACH_SUN6I=y
>>   +S:CONFIG_TARGET_MELE_M9=y
>> ++S:CONFIG_DRAM_CLK=312
>
> You are overriding this to be the default, is that deliberate/necessary?
>
> I suspect it's just to keep both or neither of CLK and ZQ explicitly
> give, which is a fine reason.

Yes, this is just here to make it easier to see what CLK and ZQ is used without
needing to look in the Kconfig, it is also here to make it a better template
for other sun6i defconfig-s

Regards,

Hans