[U-Boot] [PATCH] fs/ext4/ext4fs.c, fs/fs.c: Use lldiv and multiplication / subtraction on 64bit ops

Tom Rini trini at ti.com
Wed Nov 26 17:46:46 CET 2014


On Tue, Nov 25, 2014 at 02:45:33PM -0700, Simon Glass wrote:
> Hi Tom,
> 
> On 24 November 2014 at 12:55, Simon Glass <sjg at chromium.org> wrote:
> > On 24 November 2014 at 09:55, Tom Rini <trini at ti.com> wrote:
> >> In some cases we need to do math on 64bit quantities.  We need to be
> >> using lldiv in these cases rather than letting the compiler do it.  In
> >> addition we need to avoid doing % operations on these same quantities.
> >> These changes fix compilation on MIPS/MIPSEL.
> >>
> >> Cc: Daniel Schwierzeck <daniel.schwierzeck at gmail.com>
> >> Cc: Suriyan Ramasami <suriyan.r at gmail.com>
> >> Cc: Simon Glass <sjg at chromium.org>
> >> Signed-off-by: Tom Rini <trini at ti.com>
> >
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> I'm not sure this goes far enough. I am still seeing problems even
> with this patch, e.g. for pm9g45:

Indeed it's not.  I'll post a V2 soon, I've figured out the places I
missed but need to step out now.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141126/f0ed4614/attachment.pgp>


More information about the U-Boot mailing list