[U-Boot] [PATCH V2] cmd_i2c: Provide option for bulk 'i2c write' in one transaction

Lubomir Popov lpopov at mm-sol.com
Wed Nov 26 20:37:31 CET 2014


Hi Simon,

[snip]

>> +               while (length-- > 0) {
>> +                       if (i2c_write(chip, devaddr++, alen, memaddr++, 1) != 0)
>> +                               return i2c_report_err(-1, I2C_ERR_WRITE);
>>  /*
>>   * No write delay with FRAM devices.
>>   */

>Should this be indented?

>>  #if !defined(CONFIG_SYS_I2C_FRAM)
>> -               udelay(11000);
>> +                       udelay(11000);
>>  #endif
>> +               }

[snip]

Which indent do you mean? The udelay() is within the while loop, so it should. The
comment above your note - I kept it as is, aligned with the #if/#endif.

Regards,
Lubo




More information about the U-Boot mailing list