[U-Boot] [PATCH 2/8] ARM: UniPhier: add dummy gpio.h to enable CONFIG_OF_CONTROL

Simon Glass sjg at chromium.org
Wed Nov 26 21:18:41 CET 2014


Hi Masahiro,

On 26 November 2014 at 02:33, Masahiro Yamada <yamada.m at jp.panasonic.com> wrote:
> If CONFIG_OF_CONTROL is enabled, lib/fdtdec.c is compiled.
> It includes <asm/gpio.h> and then <asm/gpio.h> includes
> <asm/arch/gpio.h>.  Consequently, all the SoCs that enable
> CONFIG_OF_CONTROL must have <asm/arch/gpio.h> even if they do not
> support GPIO.
>
> In the first place, GPIO has nothing to do with OF_CONTROL.
> It is wrong that lib/fdtdec.c includes GPIO functions; it should
> be split into two files, FDT-common things and GPIO things.
> It is, however, a pretty big work to fix that correctly.
>
> This is a compromised commit to add a dummy <asm/arch/gpio.h>
> to support OF_CONTROL for UniPhier platform.  This dummy header
> will be removed after FDT-GPIO stuff is fixed correctly.
>
> Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
> ---
>
> I am working on the task to split lib/fdtdec.c and
> move GPIO functions to drivers/gpio/.

That code is only temporary and we can probably remove it soon. It
should move to the GPIO uclass.

Regards,
Simon


More information about the U-Boot mailing list