[U-Boot] [PATCH 7/8] ARM: UniPhier: display model name if it is available in device tree

Simon Glass sjg at chromium.org
Thu Nov 27 17:00:46 CET 2014


Hi Masahiro,

On 27 November 2014 at 07:44, Masahiro YAMADA <yamada.m at jp.panasonic.com> wrote:
> Hi Simon,
>
> 2014-11-27 5:15 GMT+09:00 Simon Glass <sjg at chromium.org>:
>> Hi Masahiro,
>>
>> On 26 November 2014 at 02:34, Masahiro Yamada <yamada.m at jp.panasonic.com> wrote:
>>> If CONFIG_OF_CONTROL is defined and the root node of the device tree
>>> has "model" property, display the model name instead of the hard-coded
>>> board name.
>>>
>>> Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
>>
>> Reviewed-by: Simon Glass <sjg at chromium.org>
>>
>> This works, but also see if CONFIG_DISPLAY_BOARDINFO_LATE works for
>> you. Or perhaps we can do this prior to relocation if
>> CONFIG_DISPLAY_BOARDINFO is not defined?
>>
>> Anyway your code is not really board-specific.
>
> I knew show_model_r() in board_r.c,
> but I want the board name information at the top of the message
> of the serial console.
>
> Maybe can ) implement show_model_f() that is similar to show_model_r().
>
> If so, I am happy to use it.

Sounds good to me. At least for platforms with no display (i.e. that
don't need to wait for stdio to be ready) this makes sense.

Regards,
Simon


More information about the U-Boot mailing list