[U-Boot] [PATCH] ftd_support: Fix regression causes by "fdt: Try to use fdt_address_cells()/fdt_size_cells()"

Simon Glass sjg at chromium.org
Thu Nov 27 17:13:12 CET 2014


On 27 November 2014 at 07:25, Simon Glass <sjg at chromium.org> wrote:
> Hi Hans,
>
> On 27 November 2014 at 03:16, Hans de Goede <hdegoede at redhat.com> wrote:
>> After commit 933cdbb479: "fdt: Try to use fdt_address_cells()/fdt_size_cells()"
>> I noticed that allwinner boards would no longer boot.
>>
>> Switching to fdt_address_cells / fdt_size_cells changes the result from
>> bytes to 32 bit words, so when we increment pointers into the blob, we must
>> do so by 32 bit words now.
>>
>> This commit makes allwinner boards boot again.
>>
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>
> Thanks for the patch.
>
> Nit time - can you please tweak the patch subject? Should be fdt: for
> the tag and try to keep under 60 chars, so something like "fdt: Fix
> regression in fdt_pack_reg()"

Should have said I'm happy to do then when I apply it if you prefer.

- Simon


More information about the U-Boot mailing list