[U-Boot] [PATCH 16/18] mmc: extend the mmc hardware partitioning API with write reliability

Pantelis Antoniou panto at antoniou-consulting.com
Fri Nov 28 15:30:27 CET 2014


Hi Diego,

> On Nov 28, 2014, at 16:27 , Diego Santa Cruz <Diego.SantaCruz at spinetix.com> wrote:
> 
> Hi Pantelis,
> 
>> I think the source of the confusion is that you've introduced user_enh_start,
>> user_enh_size in one patch and then modify them
>> again in another. That causes diff changes to show up due to the introduction
>> of the structure. How about declaring the structure
>> in the first patch and the new members in another?
>> 
> 
> Indeed, I realized the shortcoming of the first approach down the road.
> 
> I can modify the patches as you propose. As I'm fairly new to git, I would appreciate if you can point me out how to efficiently modify an intermediate commit in my git repo so that I can generate a new patch series.
> 

$ git rebase -i
<pick up the commit you want to edit and change pick to edit>
$ <make changes>
$ git add <changed-files>
$ git rebase —continue

You can take a look at something like this:

https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase

> Thanks,
> 
> Diego
> 

Regards

— Pantelis

> -- 
> Diego Santa Cruz, PhD
> Technology Architect
> spinetix.com



More information about the U-Boot mailing list