[U-Boot] [PATCH 2/2] arm: mx6: cm_fx6: use gpio request

Igor Grinberg grinberg at compulab.co.il
Fri Oct 3 08:45:15 CEST 2014


Hi Nikita,

On 10/02/14 17:17, Nikita Kiryanov wrote:
> Use gpio_request for all the gpios that are utilized by various
> subsystems in cm-fx6, and refactor the relevant init functions
> so that all gpios are requested during board_init(), not during
> subsystem init, thus avoiding the need to manage gpio ownership
> each time a subsystem is initialized.
> 
> The new division of labor is:
> During board_init() muxes are setup and gpios are requested.
> During subsystem init gpios are toggled.
> 
> Cc: Igor Grinberg <grinberg at compulab.co.il>
> Cc: Simon Glass <sjg at chromium.org>
> Signed-off-by: Nikita Kiryanov <nikita at compulab.co.il>

This looks much better.
I really don't like sticking the "has_been_inited" style of plugs,
while the same can be done by design and w/o such plugs.
Thanks Nikita.

Acked-by Igor Grinberg <grinberg at compulab.co.il>


-- 
Regards,
Igor.


More information about the U-Boot mailing list