[U-Boot] [PATCH][v2] ls102x: configs - Add hash command in freescale LS1 platforms

[Wolfgang Denk]

Dear Ruchika Gupta,

In message <1412676666-31325-1-git-send-email-ruchika.gupta at freescale.com> you wrote:
> Hardware accelerated support for SHA-1 and SHA-256 has been added.
> Hash command enabled along with hardware accelerated support for
> SHA-1 and SHA-256 for platforms which have CAAM block.

>  #define CONFIG_SYS_FSL_ESDHC_ADDR		(CONFIG_SYS_IMMR + 0x00560000)
>  #define CONFIG_SYS_FSL_SCFG_ADDR		(CONFIG_SYS_IMMR + 0x00570000)
>  #define CONFIG_SYS_FSL_SERDES_ADDR		(CONFIG_SYS_IMMR + 0x00ea0000)
> +#define CONFIG_SYS_FSL_SEC_ADDR			(CONFIG_SYS_IMMR + 0x700000)
> +#define CONFIG_SYS_FSL_JR0_ADDR			(CONFIG_SYS_IMMR + 0x710000)
>  #define CONFIG_SYS_FSL_GUTS_ADDR		(CONFIG_SYS_IMMR + 0x00ee0000)
>  #define CONFIG_SYS_FSL_LS1_CLK_ADDR		(CONFIG_SYS_IMMR + 0x00ee1000)
>  #define CONFIG_SYS_NS16550_COM1			(CONFIG_SYS_IMMR + 0x011c0500)

Would it not make sense to keep this list sorted (by growing addresses)?

> +int misc_init_r(void)
> +{
> +	if (sec_init() < 0)
> +		return -1;
> +	return 0;
> +}

Would

	return sec_init();

be equivalent?  [If so,, then please fix globally.]


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There's no future in time travel.