[U-Boot] [PATCH] print true board names on socfpga

[Albert ARIBAUD]

Hi Pavel,

On Thu, 9 Oct 2014 01:04:33 +0200, Pavel Machek <pavel at denx.de> wrote:

> On Thu 2014-10-09 00:55:59, Albert ARIBAUD wrote:
> > Hi Pavel,
> > 
> > On Thu, 9 Oct 2014 00:48:12 +0200, Pavel Machek <pavel at denx.de> wrote:
> > 
> > > On Thu 2014-10-09 00:24:34, Marek Vasut wrote:
> > > > On Thursday, October 09, 2014 at 12:12:28 AM, Pavel Machek wrote:
> > > > > On Thu 2014-10-09 00:07:04, Marek Vasut wrote:
> > > > > > On Wednesday, October 08, 2014 at 11:59:11 PM, Pavel Machek wrote:
> > > > > > > Make boards with Altera Socfpga print real board names.
> > > > > > > 
> > > > > > > Signed-off-by: Pavel Machek <pavel at denx.de>
> > > > > > 
> > > > > > Please wait with this one until the boards really reach mainline. Also,
> > > > > > the patch is missing tags in the subject, please add them in.
> > > > > 
> > > > > I wanted you to apply it to your tree. That way, the boards reach
> > > > > mainline with right names...
> > > > 
> > > > What kind of names are you referring to ? Also, I see the CC list is also broken 
> > > > :(
> > > 
> > > Read the patch.
> > > 
> > > Currently, u-boot prints confusing board names during boot.
> > 
> > I'm not sure I understand either what the patch does. It touches
> > board/altera/socfpga/socfpga_cyclone5.c, which, AFAIU, is specific to
> > one single board. So, in this patch, CONFIG_BOARD_NAME can only contain
> > the Cyclone5 board name. Does any other board use this file with a
> > different CONFIG_BOARD_NAME?
> 
> On marex's branch from 20141007
> (e8e77ee38da8760d0fa3ebdae37924db71f1e496):
> 
> pavel at amd:~/wagabuibui/u-boot$ cat board/denx/mcvevk/socfpga_cyclone5.c 
> #include "../../altera/socfpga/socfpga_cyclone5.c"

Ok, so the Denx MCV EVK board uses the same file as the Altera SoCFPGA
board, and without your patch, the Denx board would show itself as the
Altera one.

Since the list of files touched by the patch does not provide any clue
as to which other board(s) use the Altera SoCFPGA, can you post a V2 of
your patch, with an amended commit message listing the other board(s)
involved?

> Initial patch even said it is against Marek's tree...

Indeed -- I just did not realize that this board/ file was included
in another board/ file.

Regarding tags, "arm:" and "socfpga:" should be fine.

Amicalement,
-- 
Albert.